Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick f62f983b56623f0e from sqlite. #27424

Merged
merged 3 commits into from Jan 22, 2021

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Jan 20, 2021

Backport https://sqlite.org/src/info/f62f983b56623f0e.

User & Date: dan on 2020-12-22 16:23:29
Fix a problem handling sub-queries with both a correlated WHERE clause and a "HAVING 0" clause where the parent query is itself an aggregate.

Release Notes

Notes: backported the fix to CVE-2021-21120 from sqlite.

@ppontes ppontes added semver/patch backwards-compatible bug fixes backport-check-skip Skip trop's backport validity checking 11-x-y labels Jan 20, 2021
@ppontes ppontes requested a review from a team as a code owner January 20, 2021 22:25
@ppontes ppontes changed the title chore: cherry-pick f62f983b56623f0e from sqlite. [WIP] chore: cherry-pick f62f983b56623f0e from sqlite. Jan 20, 2021
@ppontes ppontes force-pushed the cherry-pick/11-x-y/sqlite/f62f983b56623f0e branch from ef80f36 to c25400b Compare January 20, 2021 22:40
@ppontes ppontes changed the title [WIP] chore: cherry-pick f62f983b56623f0e from sqlite. chore: cherry-pick f62f983b56623f0e from sqlite. Jan 20, 2021
@ppontes ppontes removed the wip ⚒ label Jan 20, 2021
@deepak1556
Copy link
Member

Thanks for porting this change

Q: was the patch made following the steps at https://chromium.googlesource.com/chromium/src/+/master/third_party/sqlite/README.md#cherry_pick-unreleased-commit-from-sqlite ?

@ppontes ppontes changed the title chore: cherry-pick f62f983b56623f0e from sqlite. [wip] chore: cherry-pick f62f983b56623f0e from sqlite. Jan 21, 2021
@ppontes ppontes force-pushed the cherry-pick/11-x-y/sqlite/f62f983b56623f0e branch from e17e5f9 to 6ef2418 Compare January 21, 2021 00:24
@ppontes ppontes changed the title [wip] chore: cherry-pick f62f983b56623f0e from sqlite. chore: cherry-pick f62f983b56623f0e from sqlite. Jan 21, 2021
@ppontes ppontes removed the wip ⚒ label Jan 21, 2021
@ppontes
Copy link
Member Author

ppontes commented Jan 21, 2021

Thanks for porting this change

Q: was the patch made following the steps at https://chromium.googlesource.com/chromium/src/+/master/third_party/sqlite/README.md#cherry_pick-unreleased-commit-from-sqlite ?

No, I wasn't aware of those instructions and they were really important to follow, thanks! Updated the backport.

@codebytere codebytere merged commit 1559dc7 into 11-x-y Jan 22, 2021
@release-clerk
Copy link

release-clerk bot commented Jan 22, 2021

Release Notes Persisted

backported the fix to CVE-2021-21120 from sqlite.

@codebytere codebytere deleted the cherry-pick/11-x-y/sqlite/f62f983b56623f0e branch January 22, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants