fix: CSP with unsafe-eval detection with Trusted Types #27446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniak
changed the title
unsafe-eval detection with Trusted Types
miniak
added
semver/none
target/10-x-y
semver/patch
miniak
force-pushed
the
miniak/unsafe-eval-trusted-types
branch
2 times, most recently
from
2deeff3
to
a49aa51
Compare
deepak1556
approved these changes
Jan 22, 2021
miniak
force-pushed
the
miniak/unsafe-eval-trusted-types
branch
from
a49aa51
to
ec8334b
Compare
koto
reviewed
Jan 22, 2021
miniak
force-pushed
the
miniak/unsafe-eval-trusted-types
branch
3 times, most recently
from
9971606
to
1c22dba
Compare
miniak
force-pushed
the
miniak/unsafe-eval-trusted-types
branch
from
1c22dba
to
6d8bcaf
Compare
zcbenz
approved these changes
Jan 25, 2021
|
Release Notes Persisted
|
|
I was unable to backport this PR to "12-x-y" cleanly; |
|
I was unable to backport this PR to "9-x-y" cleanly; |
This was referenced Jan 25, 2021
|
I have automatically backported this PR to "10-x-y", please check out #27468 |
|
I have automatically backported this PR to "11-x-y", please check out #27469 |
ckerr
pushed a commit
that referenced
this pull request
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #27211
Need to use
eval('')instead ofnew Function('')due to a bug in Trusted Types for function constructor.Before:
After:
Checklist
npm testpassesRelease Notes
Notes: Fixed CSP with
unsafe-evaldetection with Trusted Types.