Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: <webview> not working with Trusted Types #27465

Merged
merged 1 commit into from
Jan 25, 2021
Merged

fix: <webview> not working with Trusted Types #27465

merged 1 commit into from
Jan 25, 2021

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jan 25, 2021

Backport of #27445

See that PR for details.

Notes: Fixed <webview> not working with Trusted Types.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 25, 2021
@trop trop bot requested a review from miniak January 25, 2021 01:30
@trop trop bot mentioned this pull request Jan 25, 2021
Merged
4 tasks
@trop trop bot added 10-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jan 25, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 25, 2021
@codebytere
Copy link
Member

@miniak

ERROR in /home/builduser/project/src/electron/lib/renderer/web-view/web-view-impl.ts
./lib/renderer/web-view/web-view-impl.ts
[tsl] ERROR in /home/builduser/project/src/electron/lib/renderer/web-view/web-view-impl.ts(44,19)
TS2531: Object is possibly 'null'.

@miniak miniak force-pushed the trop/10-x-y-bp-fix-webview-not-working-with-trusted-types-1611538196479 branch from 530005f to 6eb1165 Compare January 25, 2021 16:54
@miniak
Copy link
Contributor

miniak commented Jan 25, 2021 •
edited

@codebytere fixed, for some reason ownerDocument is declared as nullable in the TypeScript version used in this branch

@codebytere codebytere merged commit 2e98e11 into 10-x-y Jan 25, 2021
@release-clerk
Copy link

release-clerk bot commented Jan 25, 2021

Release Notes Persisted

Fixed &lt;webview&gt; not working with Trusted Types.

@codebytere codebytere deleted the trop/10-x-y-bp-fix-webview-not-working-with-trusted-types-1611538196479 branch January 25, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@miniak miniak miniak approved these changes

Assignees
No one assigned
Labels
10-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @miniak @ckerr