Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 36abafa0a316 from v8 #27624

Merged
merged 2 commits into from Feb 5, 2021

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Feb 4, 2021

[Merged ][wasm] PostMessage of Memory.buffer should throw

PostMessage of an ArrayBuffer that is not detachable should result
in a DataCloneError.

TBR=gdeepti@chromium.org

(cherry picked from commit dfcf1e86fac0a7b067caf8fdfc13eaf3e3f445e4)

Bug: chromium:1170176, chromium:961059
No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Change-Id: Ife852df032841b7001375acd5e101d614c4b0771
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2674169
Reviewed-by: Zhi An Ng zhin@chromium.org
Commit-Queue: Zhi An Ng zhin@chromium.org
Cr-Commit-Position: refs/branch-heads/8.8@{#30}
Cr-Branched-From: 2dbcdc105b963ee2501c82139eef7e0603977ff0-refs/heads/8.8.278@{#1}
Cr-Branched-From: 366d30c99049b3f1c673f8a93deb9f879d0fa9f0-refs/heads/master@{#71094}

Notes: Security: backported fix for chromium:1170176, chromium:961059.

@nornagon nornagon requested a review from a team as a code owner February 4, 2021 19:56
@nornagon nornagon added 11-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes labels Feb 4, 2021
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Feb 4, 2021
@nornagon nornagon merged commit a017513 into 11-x-y Feb 5, 2021
@release-clerk
Copy link

release-clerk bot commented Feb 5, 2021

Release Notes Persisted

Security: backported fix for chromium:1170176, chromium:961059.

@nornagon nornagon deleted the cherry-pick/11-x-y/v8/36abafa0a316 branch February 5, 2021 17:43
@harryi3t
Copy link

@nornagon @deepak1556 Will this fix be backported to the other supported Electron release lines (v9 and v10)?

@deepak1556
Copy link
Member

It has been backported to those branches, you can find the releases 10.3.2 and 9.4.3 containing the fixes.

@harryi3t
Copy link

Thanks @deepak1556 for confirming this so quickly! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants