Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace ClearFilterData with InvalidateFilterData #27699

Merged

Conversation

rzhao271
Copy link
Contributor

Description of Change

This is a continuation of #27635. It turned out that the new InvalidateFilterData function was still not being called, so this PR replaces the ClearFilterData function with InvalidateFilterData completely.

/cc @deepak1556

Checklist

Release Notes

Notes: Fix SVG content with filter sometimes not being rendered.

@rzhao271 rzhao271 requested a review from a team as a code owner February 10, 2021 20:32
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 10, 2021
@nornagon
Copy link
Member

@rzhao271 since there's no test here, have you confirmed that this actually fixes the issue? It seems like #27635 didn't.

@rzhao271
Copy link
Contributor Author

@nornagon sorry about that. I failed to test that PR properly on my end before it got merged.

Here is a demo showing the fixed behaviour for this PR, where as soon as the app loads, the black circle shows up:

recording (1)

Here is the current faulty behaviour in 11.2.3 where one must invalidate the layout before the black circle shows up:

recording (2)

@deepak1556 deepak1556 added 11-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes labels Feb 10, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 10, 2021
@rzhao271 rzhao271 force-pushed the rzhao271/fix-svg-patch-for-realsies branch 2 times, most recently from 9fc8d5b to ce1cc5c Compare February 12, 2021 22:07
@rzhao271 rzhao271 force-pushed the rzhao271/fix-svg-patch-for-realsies branch from ce1cc5c to db014c8 Compare February 13, 2021 01:42
@deepak1556 deepak1556 requested review from a team February 13, 2021 08:44
@zcbenz zcbenz merged commit 715ffe4 into electron:11-x-y Feb 15, 2021
@release-clerk
Copy link

release-clerk bot commented Feb 15, 2021

Release Notes Persisted

Fix SVG content with filter sometimes not being rendered.

@rzhao271 rzhao271 deleted the rzhao271/fix-svg-patch-for-realsies branch February 15, 2021 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants