Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check WebContents before emitting render-process-gone event #27758

Merged
merged 1 commit into from
Feb 17, 2021
Merged

fix: check WebContents before emitting render-process-gone event #27758

merged 1 commit into from
Feb 17, 2021

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented Feb 17, 2021

Backport of #27730

See that PR for details.

Notes: Fix crash when destroying WebContents in the crashed event.

@zcbenz zcbenz added backport This is a backport PR semver/patch backwards-compatible bug fixes 10-x-y labels Feb 17, 2021
@trop trop bot mentioned this pull request Feb 17, 2021
Merged
5 tasks
@zcbenz zcbenz force-pushed the render-process-gone-crash-10 branch from 6a2a290 to c3f6dce Compare February 17, 2021 12:45
@codebytere codebytere merged commit 779efcf into 10-x-y Feb 17, 2021
@release-clerk
Copy link

release-clerk bot commented Feb 17, 2021

Release Notes Persisted

Fix crash when destroying WebContents in the crashed event.

@codebytere codebytere deleted the render-process-gone-crash-10 branch February 17, 2021 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
10-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zcbenz @nornagon @codebytere