fix: crash in crypto.createDiffieHellman #27766

deepak1556 · 2021-02-17T21:54:28Z

Backports #27674

PR description included and stakeholders cc'd
npm test passes
tests are changed or added
relevant documentation is changed or added
PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Notes: Fixed a crash when calling crypto.createDiffieHellman() with certain parameters.

release-clerk · 2021-02-18T01:34:59Z

Release Notes Persisted

Fixed a crash when calling crypto.createDiffieHellman() with certain parameters.

fix: crash in crypto.createDiffieHellman

e0ade91

deepak1556 requested a review from a team as a code owner February 17, 2021 21:54

electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 17, 2021

deepak1556 requested a review from codebytere February 17, 2021 21:54

deepak1556 added the backport-check-skip Skip trop's backport validity checking label Feb 17, 2021

electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 17, 2021

deepak1556 added 11-x-y semver/patch backwards-compatible bug fixes labels Feb 17, 2021

codebytere approved these changes Feb 17, 2021

View reviewed changes

zcbenz approved these changes Feb 18, 2021

View reviewed changes

zcbenz merged commit f30018b into 11-x-y Feb 18, 2021

zcbenz deleted the robo/fixup-diffiehellman-issues_11_x_y branch February 18, 2021 01:34

deepak1556 mentioned this pull request Feb 20, 2021

"Extension host terminated unexpectedly" on ftp syncronization microsoft/vscode#116727

Closed

Provide feedback