Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 62bda83979 from chromium #27779

Merged
merged 1 commit into from Feb 18, 2021
Merged

Conversation

deepak1556
Copy link
Member

Disable GPU acceleration on all Mesa software rasterizers

The previous entry only disabled acceleration on swrast, but softpipe
and llvmpipe shouldn't be used for "GPU" acceleration either.
This should apply to Linux but not ChromeOS, AFAICT.

This only improves an existing software rendering list entry, but here
is the rationale: We prefer to rely on our own (domain specific, so more
efficient) software paths, at least for everything other than WebGL. And
for WebGL, SwiftShader avoids unknown factors like
llvmpipe/softpipe/swrast.

If you are running a Mesa GL driver (not e.g. NVIDIA) then you can force
these configurations with:

The GL_RENDERER strings are:

  • swrast: "Software Rasterizer" (couldn't test this locally; found this online)
  • softpipe: "softpipe" (on one machine)
  • llvmpipe: "llvmpipe (LLVM 10.0.0, 256 bits)" (on one machine)

Drive-by updates the description of another item to be more accurate
(SVGA3D is virtualized over hardware; it's not a software renderer).

Unrelated CQ failures on branch

(cherry picked from commit 7c7eccfc85e387a0dcd154a2a9c2389177982837)

No-Try: True
Bug: 1155974
Change-Id: I0571c1a1bf526260f7ea6cd53f88eec768973b13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645491
Commit-Queue: Kai Ninomiya kainino@chromium.org
Reviewed-by: Zhenyao Mo zmo@chromium.org
Auto-Submit: Kai Ninomiya kainino@chromium.org
Cr-Original-Commit-Position: refs/heads/master@{#846422}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2651183
Reviewed-by: Kenneth Russell kbr@chromium.org
Cr-Commit-Position: refs/branch-heads/4324@{#2176}
Cr-Branched-From: c73b5a651d37a6c4d0b8e3262cc4015a5579c6c8-refs/heads/master@{#827102}

Notes: Security: backported fix for 1155974.

@deepak1556 deepak1556 requested a review from a team as a code owner February 18, 2021 10:32
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 18, 2021
@deepak1556 deepak1556 added 11-x-y backport-check-skip Skip trop's backport validity checking labels Feb 18, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 18, 2021
@deepak1556 deepak1556 added the semver/patch backwards-compatible bug fixes label Feb 18, 2021
@codebytere codebytere merged commit e33df2c into 11-x-y Feb 18, 2021
@release-clerk
Copy link

release-clerk bot commented Feb 18, 2021

Release Notes Persisted

Security: backported fix for 1155974.

@codebytere codebytere deleted the robo/backport_1155974 branch February 18, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants