fix: make TouchBarPopover and TouchBarGroup work #27901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
erickzhao
force-pushed
the
erick/touchbar
branch
from
86a37f7
to
5b8bd57
Compare
MarshallOfSound
approved these changes
Feb 27, 2021
codebytere
approved these changes
Mar 1, 2021
|
Release Notes Persisted
|
|
This has been merged 4 weeks ago, I thought that the yesterday v12 release could include it, but it's still broken, any ETA for the backport of the PR to v11 and v12 that are affected by the problem? |
|
@ggreco I forgot to add the proper backport labels for this process to be automated. I'll have to apply these backports manually. Thanks for checking in! |
erickzhao
added a commit
to erickzhao/ericktron
that referenced
this pull request
Mar 26, 2021
* fix: use correct `orderedItem` touchbar property * fix: correct parent in touchbar group and popover * fix: preserve property hook order
|
@erickzhao has manually backported this PR to "12-x-y", please check out #28411 |
erickzhao
added a commit
to erickzhao/ericktron
that referenced
this pull request
Mar 26, 2021
* fix: use correct `orderedItem` touchbar property * fix: correct parent in touchbar group and popover * fix: preserve property hook order
|
@erickzhao has manually backported this PR to "11-x-y", please check out #28412 |
codebytere
pushed a commit
that referenced
this pull request
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #26615
257cca0: The
ordereredItemsproperty was renamed toorderedItems, but this typo was never fixed at the Objective-C layer, leading to early exits when creatingTouchBarGroupandTouchBarPopoveritems.5b8bd57: As pointed out in #26615 (comment) and #26615 (comment), items inside a TouchBarGroup or TouchBarPopover would add themselves as a parent.
43e108b: Before this change, when adding a new
@ImmutablePropertyor@LiveProperty, its constructor hook would be called before the existing hooks before it. This caused a bug when instantiating Popovers and Groups -- even though we set theidproperty first, it would beundefinedwhen we used its value in the hook for thechildproperty a few lines later.Tester code (adapted from #9025): https://gist.github.com/10e5c142126b439282b97cd762a24d55
cc @MarshallOfSound
Checklist
npm testpassesRelease Notes
Notes: Fixed bug where TouchBarPopover and TouchBarGroup were no longer rendering