Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 7e0e52df283c from chromium #28046

Merged
merged 2 commits into from
Mar 8, 2021

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Mar 8, 2021

[Blobs] Don't store BlobStorageLimits as a reference in transport strategy.

Rather than storing a const reference to something of unclear lifetime,
just make a copy. We could just copy the specific limits we need, but
there shouldn't be many TransportStrategy instances alive at the same
time anyway, so the cost of duplicating shouldn't be too high.

(cherry picked from commit 9a10c68a381d78088532953aa8e0de0a5ff47316)

(cherry picked from commit 7b51cb5e4e2c6cf9dcf19bd9d7599735efd48110)

Bug: 1180871
Change-Id: Ie1e31728b18f02c5d35df0ac0f285eb8f70cb268
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2713912
Reviewed-by: Olivier Yiptong oyiptong@chromium.org
Reviewed-by: Darwin Huang huangdarwin@chromium.org
Reviewed-by: Victor Costan pwnall@chromium.org
Commit-Queue: Marijn Kruisselbrink mek@chromium.org
Cr-Original-Original-Commit-Position: refs/heads/master@{#856503}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2713891
Reviewed-by: Krishna Govind govind@chromium.org
Reviewed-by: Srinivas Sista srinivassista@chromium.org
Cr-Original-Commit-Position: refs/branch-heads/4425@{#2}
Cr-Original-Branched-From: 4a7d24ec28ccb96c5a1cfd7b4b40b17070f2c396-refs/heads/master@{#856252}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2713958
Commit-Queue: Krishna Govind govind@chromium.org
Cr-Commit-Position: refs/branch-heads/4389@{#1327}
Cr-Branched-From: 9251c5db2b6d5a59fe4eac7aafa5fed37c139bb7-refs/heads/master@{#843830}

Notes: Security: backported fix for 1180871.

@ppontes ppontes requested a review from a team as a code owner March 8, 2021 16:04
@ppontes ppontes added 11-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes labels Mar 8, 2021
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Mar 8, 2021
@jkleinsc
Copy link
Contributor

jkleinsc commented Mar 8, 2021

Merging as CI failure is known flake unrelated to this PR.

@jkleinsc jkleinsc merged commit 4a5a18f into 11-x-y Mar 8, 2021
@release-clerk
Copy link

release-clerk bot commented Mar 8, 2021

Release Notes Persisted

Security: backported fix for 1180871.

@MarshallOfSound MarshallOfSound deleted the cherry-pick/11-x-y/chromium/7e0e52df283c branch February 8, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants