Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename process.contextIsolation to process.contextIsolated #28259

Merged
merged 2 commits into from
Mar 18, 2021

Conversation

MarshallOfSound
Copy link
Member

Discussed in api-wg --> https://electronhq.slack.com/archives/CNL6E1GJD/p1616022446002700

I've updated the notes of the original PR (#28030) and will cherry pick this commit onto the backport shortly

Notes: no-notes

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 17, 2021
@codebytere
Copy link
Member

@MarshallOfSound what semver tag should this get?

@miniak
Copy link
Contributor

miniak commented Mar 18, 2021

@MarshallOfSound can also you fix

it('reports process.contextIsolation', async () => {
const iw = new BrowserWindow({
show: false,
webPreferences: {
contextIsolation: true,
preload: path.join(fixtures, 'api', 'isolated-process.js')
}
});
const p = emittedOnce(ipcMain, 'context-isolation');
iw.loadURL('about:blank');
const [, contextIsolation] = await p;
expect(contextIsolation).to.be.true('contextIsolation');
});
});

@MarshallOfSound MarshallOfSound added the semver/patch backwards-compatible bug fixes label Mar 18, 2021
@MarshallOfSound MarshallOfSound merged commit f35fc93 into master Mar 18, 2021
@MarshallOfSound MarshallOfSound deleted the fix-ctx-iso-prop branch March 18, 2021 21:00
@release-clerk
Copy link

release-clerk bot commented Mar 18, 2021

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-pr 🌱 PR opened in the last 24 hours semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants