Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick a66dbdcf6493 from chromium #28294

Merged
merged 2 commits into from Mar 22, 2021

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Mar 19, 2021

Reland "Reland "[FSA] Add IsSafePathComponent checks to GetFile/GetDirectoryHandle.""

This is a reland of 2d41c3952d2851948a09ddcf3e97bae6c419b024

The added test was modified to no longer assert that all unsafe files
were written to disk successfully. This should make the test pass (albeit
with less stringent checks) on file systems/platforms that don't allow
all unsafe file names.

Original change's description:

Reland "[FSA] Add IsSafePathComponent checks to GetFile/GetDirectoryHandle."

This is a reland of 004377929febd7cf7392932b01df7f4a0a362679

The main difference is to make sure iterating over a directory doesn't
return files we don't want to expose either (and not CHECK failing if
such files are found when iterating).

Original change's description:

[FSA] Add IsSafePathComponent checks to GetFile/GetDirectoryHandle.

This isn't directly using net::IsSafePortablePathComponent since what
is safe for the File System Access API is not the same as what is safe
for Downloads. As such currently this duplicates a lot of the
implementation of this method, but in a followup we should attempt to
unify these two implementations as much as possible.

Bug: 1150810, 1154757
Change-Id: Iba4c92ef5f1cd924aa22b9dd201762d48b4bbc3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568383
Commit-Queue: Marijn Kruisselbrink mek@chromium.org
Reviewed-by: Victor Costan pwnall@chromium.org
Cr-Commit-Position: refs/heads/master@{#833042}

Bug: 1150810
Bug: 1154757
Change-Id: I3341b9824a1ac4cbd6f100355960ad55b01f0753
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575370
Commit-Queue: Victor Costan pwnall@chromium.org
Reviewed-by: Victor Costan pwnall@chromium.org
Cr-Commit-Position: refs/heads/master@{#834118}

Bug: 1150810
Bug: 1154757
Change-Id: Ie5cad9a7b2383c89b96e8a7be6cfe75ad2555fa6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577614
Commit-Queue: Marijn Kruisselbrink mek@chromium.org
Auto-Submit: Marijn Kruisselbrink mek@chromium.org
Reviewed-by: Victor Costan pwnall@chromium.org
Cr-Commit-Position: refs/heads/master@{#834598}

Notes: Security: backported fix for CVE-2021-21172.

@ppontes ppontes requested a review from a team as a code owner March 19, 2021 13:15
@ppontes ppontes added 11-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes labels Mar 19, 2021
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Mar 19, 2021
@codebytere codebytere merged commit 3159ede into 11-x-y Mar 22, 2021
@release-clerk
Copy link

release-clerk bot commented Mar 22, 2021

Release Notes Persisted

Security: backported fix for CVE-2021-21172.

@codebytere codebytere deleted the cherry-pick/11-x-y/chromium/a66dbdcf6493 branch March 22, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants