fix: ensure widget size is set correctly on linux on small screens #28757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
When creating a widget on linux the bounds are restricted to the screen size, when calling SetSize / SetBounds they are not. This fixes this initialization issue by calling SetBounds after widget creation. Noticed this issue while running linux tests on xvfb with a screen size smaller than the default electron window size (resulted in a failed test).
trop
bot
added
11-x-y
backport
codebytere
approved these changes
Apr 21, 2021
jkleinsc
approved these changes
Apr 21, 2021
|
Merging as CI failure is known flake unrelated to this PR. |
|
No Release Notes |
jkleinsc
deleted the
trop/11-x-y-bp-fix-ensure-widget-size-is-set-correctly-on-linux-on-small-screens-1618995553925
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #28681
See that PR for details.
Notes: no-notes