Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle async nature of [NSWindow -toggleFullScreen] #28773

Merged
merged 1 commit into from
Apr 22, 2021
Merged

fix: handle async nature of [NSWindow -toggleFullScreen] #28773

merged 1 commit into from
Apr 22, 2021

Conversation

codebytere
Copy link
Member

Backport of #25470.

See that PR for details.

Notes: Fixed an issue where multiple calls to window.setFullScreen could cause problems.

@codebytere codebytere requested a review from a team April 22, 2021 07:18
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 22, 2021
@trop trop bot mentioned this pull request Apr 22, 2021
Merged
4 tasks
@trop trop bot added 11-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Apr 22, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 22, 2021
jkleinsc
jkleinsc requested changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is a reference to the removed exiting_fullscreen_:
https://app.circleci.com/pipelines/github/electron/electron/38352/workflows/42ae2e12-8c0f-42f8-953d-97827e9dfe74/jobs/845355

@codebytere codebytere merged commit e1a71b0 into 11-x-y Apr 22, 2021
@release-clerk
Copy link

release-clerk bot commented Apr 22, 2021

Release Notes Persisted

Fixed an issue where multiple calls to window.setFullScreen could cause problems.

@codebytere codebytere deleted the async-window-11 branch April 22, 2021 18:19
@jtvberg jtvberg mentioned this pull request Apr 5, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
11-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @jkleinsc