Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick f79751ee25 from chromium #28779

Merged
merged 6 commits into from Apr 27, 2021

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Apr 22, 2021

[m90] DevTools: expect PageHandler may be destroyed during Page.navigate

(cherry picked from commit ff5e70191ec701cce4f84aaa25cd676376253a8a)

Bug: 1188889
Change-Id: I5c2fcca84834d66c46d77a70683212c2330177a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2787756
Commit-Queue: Andrey Kosyakov caseq@chromium.org
Reviewed-by: Dmitry Gozman dgozman@chromium.org
Reviewed-by: Karan Bhatia karandeepb@chromium.org
Cr-Original-Commit-Position: refs/heads/master@{#867507}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2798538
Cr-Commit-Position: refs/branch-heads/4430@{#968}
Cr-Branched-From: e5ce7dc4f7518237b3d9bb93cccca35d25216cbe-refs/heads/master@{#857950}

Release Notes

Notes: Security: Backported fix to CVE-2021-21202.

@ppontes ppontes added semver/patch backwards-compatible bug fixes backport-check-skip Skip trop's backport validity checking 11-x-y labels Apr 22, 2021
@ppontes ppontes requested a review from a team as a code owner April 22, 2021 14:57
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a needed patch was accidentally deleted.

@ppontes ppontes changed the title chore: cherry-pick f79751ee25 from chromium [WIP] chore: cherry-pick f79751ee25 from chromium Apr 22, 2021
@ppontes ppontes force-pushed the cherry-pick/11-x-y/chromium/f79751ee25 branch from be74cd3 to 1fb8d55 Compare April 22, 2021 18:03
@ppontes ppontes changed the title [WIP] chore: cherry-pick f79751ee25 from chromium chore: cherry-pick f79751ee25 from chromium Apr 22, 2021
@ppontes ppontes removed the wip ⚒ label Apr 22, 2021
@ppontes
Copy link
Member Author

ppontes commented Apr 22, 2021

Looks like a needed patch was accidentally deleted.

Thanks for spotting this, it's been fixed.

@codebytere codebytere dismissed jkleinsc’s stale review April 26, 2021 07:44

Deleted patch resolved

@zcbenz zcbenz merged commit d124760 into 11-x-y Apr 27, 2021
@release-clerk
Copy link

release-clerk bot commented Apr 27, 2021

Release Notes Persisted

Security: Backported fix to CVE-2021-21202.

@zcbenz zcbenz deleted the cherry-pick/11-x-y/chromium/f79751ee25 branch April 27, 2021 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants