Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't warn about enableRemoteModule when it's undefined #29023

Merged
merged 2 commits into from May 13, 2021
Merged

fix: don't warn about enableRemoteModule when it's undefined #29023

merged 2 commits into from May 13, 2021

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented May 5, 2021 •
edited by codebytere

Description of Change

Closes #29020.

Checklist

Release Notes

Notes: Fixed an incorrect warning about enableRemoteModule being issued when the option was undefined (and thus defaulting to false).

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 5, 2021
@nornagon nornagon added the backport-check-skip Skip trop's backport validity checking label May 5, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 5, 2021
@MarshallOfSound MarshallOfSound added semver/patch backwards-compatible bug fixes target/13-x-y labels May 5, 2021
zcbenz
zcbenz requested changes May 6, 2021
View reviewed changes
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing:

2 tests failed
  out of 1723
security warnings without sandbox should warn about enabled remote module with remote content
security warnings with sandbox should warn about enabled remote module with remote content

codebytere
codebytere requested changes May 7, 2021
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nornagon this should target master unless i'm mistaken?

@codebytere codebytere mentioned this pull request May 7, 2021
Merged
@miniak
Copy link
Contributor

miniak commented May 8, 2021

@codebytere the remote module is gone in master

@codebytere codebytere merged commit 2ed8e63 into 11-x-y May 13, 2021
@release-clerk
Copy link

release-clerk bot commented May 13, 2021

Release Notes Persisted

Fixed an incorrect warning about enableRemoteModule being issued when the option was undefined (and thus defaulting to false).

@codebytere codebytere deleted the nornagon-patch-1 branch May 13, 2021 08:47
@miniak
Copy link
Contributor

miniak commented Jun 15, 2021

/trop run backport-to 12-x-y

@trop
Copy link
Contributor

trop bot commented Jun 15, 2021

The backport process for this PR has been manually initiated - sending your PR to 12-x-y!

@trop trop bot mentioned this pull request Jun 15, 2021
Merged
@trop
Copy link
Contributor

trop bot commented Jun 15, 2021

I have automatically backported this PR to "12-x-y", please check out #29701

This was referenced Jun 15, 2021
Merged
Closed
@miniak miniak mentioned this pull request Jun 15, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere codebytere approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nornagon @miniak @zcbenz @codebytere @MarshallOfSound