Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove blink-worker-enable-csp-in-file-scheme.patch #29136

Merged
merged 2 commits into from May 17, 2021

Conversation

nornagon
Copy link
Member

Description of Change

Due to #19150 this patch has no
effect, since we crash when loading service workers from file scheme.

Long term, the right answer here is to only support service workers on custom
schemes.

Checklist

  • PR description included and stakeholders cc'd
  • relevant documentation is changed or added

Release Notes

Notes: none

@nornagon nornagon requested a review from a team as a code owner May 12, 2021 23:51
@nornagon nornagon requested a review from deepak1556 May 12, 2021 23:51
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 12, 2021
@nornagon nornagon added no-backport semver/patch backwards-compatible bug fixes labels May 12, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 13, 2021
@nornagon nornagon merged commit 8f7a385 into master May 17, 2021
@release-clerk
Copy link

release-clerk bot commented May 17, 2021

No Release Notes

@nornagon nornagon deleted the drop-file-csp-patch branch May 17, 2021 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants