Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove blink_fix_prototype_assert #29194

Merged
merged 1 commit into from May 18, 2021
Merged

chore: remove blink_fix_prototype_assert #29194

merged 1 commit into from May 18, 2021

Conversation

nornagon
Copy link
Member

Description of Change

Checking to see if this is still needed.

cc @zcbenz, is the test suite enough to catch the issue that this fixes?

Checklist

Release Notes

Notes: none

@nornagon nornagon requested a review from a team as a code owner May 17, 2021 20:44
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 17, 2021
@nornagon nornagon added semver/patch backwards-compatible bug fixes no-backport labels May 17, 2021
zcbenz
zcbenz approved these changes May 18, 2021
View reviewed changes
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original issue is #13316.

It seems that the crash used to happen randomly when running tests, so I'm not sure if we are still going to see the crash. But I'm good removing the patch to have a try.

@nornagon
Copy link
Member Author

looks like still need a @electron/wg-upgrades review

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 18, 2021
@nornagon nornagon merged commit 9b164e5 into master May 18, 2021
@release-clerk
Copy link

release-clerk bot commented May 18, 2021

No Release Notes

@nornagon nornagon deleted the remove-blink_fix_prototype_assert branch May 18, 2021 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees
No one assigned
Labels
no-backport semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nornagon @zcbenz @deepak1556