Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update the macos Dock Instructions #29197

Merged
merged 5 commits into from May 19, 2021
Merged

docs: Update the macos Dock Instructions #29197

merged 5 commits into from May 19, 2021

Conversation

tonyferrell
Copy link
Contributor

@tonyferrell tonyferrell commented May 17, 2021 •
edited

Description of Change

Updates the fiddle example for macOs Dock files to work correctly with 12.0.7.

Checklist

Release Notes

Notes: none

cc @erickzhao

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 17, 2021
@tonyferrell tonyferrell changed the title Update the macos Dock Instructions docs: Update the macos Dock Instructions May 17, 2021
@tonyferrell tonyferrell mentioned this pull request May 17, 2021
Closed
erickzhao
erickzhao reviewed May 17, 2021
View reviewed changes
docs/fiddles/features/macos-dock-menu/main.js Outdated Show resolved Hide resolved
docs/fiddles/features/macos-dock-menu/preload.js Outdated Show resolved Hide resolved
docs/fiddles/features/macos-dock-menu/main.js Outdated Show resolved Hide resolved
molant
molant approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@molant molant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

erickzhao
erickzhao reviewed May 18, 2021
View reviewed changes
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one comment

docs/fiddles/features/macos-dock-menu/index.html Show resolved Hide resolved
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 19, 2021
@zcbenz zcbenz merged commit 071fa2a into electron:master May 19, 2021
@release-clerk
Copy link

release-clerk bot commented May 19, 2021

No Release Notes

This was referenced May 19, 2021
Merged
Merged
@trop
Copy link
Contributor

trop bot commented May 19, 2021

I have automatically backported this PR to "13-x-y", please check out #29220

@trop trop bot removed the target/13-x-y label May 19, 2021
@trop
Copy link
Contributor

trop bot commented May 19, 2021

I have automatically backported this PR to "12-x-y", please check out #29221

@tonyferrell tonyferrell deleted the docs-macos-dock branch May 19, 2021 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molant molant molant approved these changes

@zcbenz zcbenz zcbenz approved these changes

@erickzhao erickzhao erickzhao approved these changes

Assignees
No one assigned
Labels
documentation 📓 semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tonyferrell @molant @zcbenz @erickzhao