Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use base::Time::Now() directly #29331

Merged
merged 1 commit into from
May 26, 2021
Merged

chore: use base::Time::Now() directly #29331

merged 1 commit into from
May 26, 2021

Conversation

dsanders11
Copy link
Member

Description of Change

Just a code hygiene change, suggested by clang-tidy. Access the static method directly through the class instead of creating an instance. Makes this usage consistent with the rest of the code base.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 26, 2021
@deepak1556
Copy link
Member

Failing test is unrelated, merging.

@deepak1556 deepak1556 merged commit ac079f1 into electron:master May 26, 2021
@release-clerk
Copy link

release-clerk bot commented May 26, 2021

No Release Notes

@dsanders11 dsanders11 deleted the patch-22 branch March 14, 2022 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees
No one assigned
Labels
new-pr 🌱 PR opened in the last 24 hours no-backport semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dsanders11 @deepak1556