Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use =default for default constructors/destructors #29511

Merged
merged 1 commit into from Jun 4, 2021
Merged

chore: use =default for default constructors/destructors #29511

merged 1 commit into from Jun 4, 2021

Conversation

dsanders11
Copy link
Member

Description of Change

Per the Chromium style guide, and one of the clang-tidy checks which Chromium has enabled.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 3, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 4, 2021
@zcbenz zcbenz merged commit 81c5da5 into electron:main Jun 4, 2021
@release-clerk
Copy link

release-clerk bot commented Jun 4, 2021

No Release Notes

@dsanders11 dsanders11 deleted the use-default-constructor-destructor branch March 14, 2022 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees
No one assigned
Labels
no-backport semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dsanders11 @zcbenz @deepak1556