New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure custom traffic lights float to top #29595
Conversation
661af4e
to
bbece09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing/adding a view is a high cost operation, it is not appropriate to do in RedrawTrafficLights
, which is frequently called in events unrelated to browser views.
Also RedrawTrafficLights
is not invoked when browser view is added/removed, this fix probably only worked because there were some window events happened to occur. So I think we should add a new helper function to reorder buttons_view_
and only call it when necessary.
@zcbenz i think that should do it! |
4ca9c1e
to
549be97
Compare
549be97
to
424ead0
Compare
Release Notes Persisted
|
I was unable to backport this PR to "13-x-y" cleanly; |
I have automatically backported this PR to "14-x-y", please check out #29628 |
@codebytere has manually backported this PR to "13-x-y", please check out #29663 |
Description of Change
Closes #29541.
Fixes an issue that surfaced as a result of 8bf66f8, where custom traffic lights could show underneath a BrowserView (e.g. wouldn't always be floated to the top of the view hierarchy). This fixes that.
Checklist
npm test
passesRelease Notes
Notes: Fixed an issue where custom traffic lights could be covered by BrowserViews on macOS.