Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure custom traffic lights float to top #29595

Merged
merged 2 commits into from Jun 10, 2021

Conversation

codebytere
Copy link
Member

Description of Change

Closes #29541.

Fixes an issue that surfaced as a result of 8bf66f8, where custom traffic lights could show underneath a BrowserView (e.g. wouldn't always be floated to the top of the view hierarchy). This fixes that.

Checklist

Release Notes

Notes: Fixed an issue where custom traffic lights could be covered by BrowserViews on macOS.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/13-x-y labels Jun 8, 2021
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 8, 2021
@codebytere codebytere force-pushed the fix-traffic-lights-overlaid branch from 661af4e to bbece09 Compare June 8, 2021 20:50
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing/adding a view is a high cost operation, it is not appropriate to do in RedrawTrafficLights, which is frequently called in events unrelated to browser views.

Also RedrawTrafficLights is not invoked when browser view is added/removed, this fix probably only worked because there were some window events happened to occur. So I think we should add a new helper function to reorder buttons_view_ and only call it when necessary.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 9, 2021
@codebytere
Copy link
Member Author

@zcbenz i think that should do it!

@codebytere codebytere merged commit 63cc82d into main Jun 10, 2021
@codebytere codebytere deleted the fix-traffic-lights-overlaid branch June 10, 2021 12:52
@release-clerk
Copy link

release-clerk bot commented Jun 10, 2021

Release Notes Persisted

Fixed an issue where custom traffic lights could be covered by BrowserViews on macOS.

@trop
Copy link
Contributor

trop bot commented Jun 10, 2021

I was unable to backport this PR to "13-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Jun 10, 2021

I have automatically backported this PR to "14-x-y", please check out #29628

@trop
Copy link
Contributor

trop bot commented Jun 13, 2021

@codebytere has manually backported this PR to "13-x-y", please check out #29663

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: BrowserView cover the TrafficLightButton of the BrowserWindow
3 participants