Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use relative links within docs #29651

Merged
merged 1 commit into from Jun 14, 2021

Conversation

dsanders11
Copy link
Member

Description of Change

Use relative links within the docs, which ensures the relative link linting keeps them from going stale. Also makes sure links stay on the same docs site, instead of linking from the new beta docs site back to the current docs site.

Checklist

  • PR description included and stakeholders cc'd

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 12, 2021
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the lint check passes. Thanks!

Don't think this needs a backport because the links should be valid for the moment.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 14, 2021
@erickzhao erickzhao added new-pr 🌱 PR opened in the last 24 hours no-backport labels Jun 14, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 14, 2021
@ckerr ckerr merged commit 7019713 into electron:main Jun 14, 2021
@release-clerk
Copy link

release-clerk bot commented Jun 14, 2021

No Release Notes

@dsanders11 dsanders11 deleted the docs-relative-links-2 branch June 14, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants