Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: re-enable some skipped tests #29655

Merged
merged 2 commits into from Jun 15, 2021
Merged

test: re-enable some skipped tests #29655

merged 2 commits into from Jun 15, 2021

Conversation

dsanders11
Copy link
Member

@dsanders11 dsanders11 commented Jun 12, 2021 •
edited

Description of Change

These tests were marked as skip, but pass on main on macOS. I think they may have just never been re-enabled. One test in a describe still failed so I marked it as it.skip.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes

Release Notes

Notes: none

zcbenz
zcbenz approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that the re-enabled tests are passing.

@zcbenz zcbenz merged commit 214fcfc into electron:main Jun 15, 2021
@release-clerk
Copy link

release-clerk bot commented Jun 15, 2021

No Release Notes

@dsanders11 dsanders11 deleted the enable-tests branch March 14, 2022 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
no-backport semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dsanders11 @zcbenz