chore: bumping NAN dep to include test changes #29686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
approved these changes
Jun 14, 2021
codebytere
approved these changes
Jun 15, 2021
nornagon
approved these changes
Jun 15, 2021
jkleinsc
approved these changes
Jun 15, 2021
|
No Release Notes |
|
I have automatically backported this PR to "14-x-y", please check out #29713 |
BlackHole1
pushed a commit
to BlackHole1/electron
that referenced
this pull request
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The current version of NAN is v2.14.2 which was released on 13 Oct 2020, about 8 months ago. In the time since, there have been two commits to the NAN repo that eliminate both of our NAN patches. This PR bumps the version of NAN to that commit with the test changes which eliminates our duplicate patches.
This should be safe as we are still using "the same" version of NAN that our users are using, only with changes to the tests we run. Additionally, it doesn't make much sense to ask the maintainers of NAN to make a release when there are no actual changes to NAN pending, especially when we have a simple escape hatch of targeting a specific commit instead.
Fixes #29284.
Checklist
npm testpassesRelease Notes
Notes: none