Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow ppapi processes access to resource bundle on all platforms #29831

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jun 22, 2021

Backport of #29827

See that PR for details.

Notes: Fixed an issue with PDF loading on Windows, where metadata was not loading correctly and causing the PDF to load as a blank page.

@trop trop bot requested a review from a team as a code owner June 22, 2021 03:47
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 22, 2021
@trop trop bot requested a review from VerteDinde June 22, 2021 03:47
@trop trop bot added 14-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jun 22, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 22, 2021
@zcbenz zcbenz merged commit 8cd0c81 into 14-x-y Jun 22, 2021
@zcbenz zcbenz deleted the trop/14-x-y-bp-fix-allow-ppapi-processes-access-to-resource-bundle-on-all-platforms-1624333625174 branch June 22, 2021 05:59
@release-clerk
Copy link

release-clerk bot commented Jun 22, 2021

Release Notes Persisted

Fixed an issue with PDF loading on Windows, where metadata was not loading correctly and causing the PDF to load as a blank page.

@WeMissing
Copy link

The PDF is Still Blank

@WeMissing
Copy link

pageCode:
$popupContentShow.append(
"<iframe src='/static/libs/PDF.js/web/viewer.html?file=" + contentPath + "' width='100%' height='100%'></iframe>"
);

The Chrome Browser Show Ok ,But Electron Show As a blank

@vapour
Copy link

vapour commented Sep 29, 2021

also not working.
window.open('https://domain.com/path/to/hello.pdf');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
14-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants