webcontents: notify guests of embedders' zoom level change #3010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1034,6 +1036,25 @@ void WebContents::OnRendererMessageSync(const base::string16& channel, | |||
| } | |||
|
|
|||
| // static | |||
| bool WebContents::NotifyZoomLevelChanged( | |||
There was a problem hiding this comment.
We can make this an anonymous function instead of WebContent's method, since it is only used in one place and doesn't access WebContent's members.
deepak1556
force-pushed
the
guest_zoom_level_patch
branch
from
b3e8733
to
e8de0b6
Compare
deepak1556
force-pushed
the
guest_zoom_level_patch
branch
from
e8de0b6
to
7756bb6
Compare
|
👍 |
zcbenz
added a commit
that referenced
this pull request
Oct 8, 2015
webcontents: notify guests of embedders' zoom level change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #940
One possible way as discussed with @zcbenz