Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow colored tray titles when font type is specified #30164

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jul 15, 2021

Backport of #30146

See that PR for details.

Notes: Fixed tray.setTitle not respecting ANSI colors if a font type was specified.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 15, 2021
@trop trop bot requested a review from nornagon July 15, 2021 23:45
@trop trop bot added 14-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jul 15, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 15, 2021
@zcbenz zcbenz merged commit 32c14a8 into 14-x-y Jul 27, 2021
@zcbenz zcbenz deleted the trop/14-x-y-bp-fix-allow-colored-tray-titles-when-font-type-is-specified-1626392738681 branch July 27, 2021 00:15
@release-clerk
Copy link

release-clerk bot commented Jul 27, 2021

Release Notes Persisted

Fixed tray.setTitle not respecting ANSI colors if a font type was specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
14-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants