Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update to the use of arrow functions in line with the style guide #30194

Merged
merged 3 commits into from Aug 2, 2021
Merged

docs: Update to the use of arrow functions in line with the style guide #30194

merged 3 commits into from Aug 2, 2021

Conversation

flyme2bluemoon
Copy link
Contributor

@flyme2bluemoon flyme2bluemoon commented Jul 19, 2021

Description of Change

Updating the tutorial docs so that the code examples use the new Javascript arrow function syntax rather than the old function () {...} syntax to be in line with Electron coding style guide.

Checklist

Release Notes

Notes: none

@welcome
Copy link

welcome bot commented Jul 19, 2021

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 19, 2021
@ckerr
Copy link
Member

ckerr commented Jul 19, 2021

Linter issues:

   tutorial/automated-testing-with-a-custom-driver.md
         88:25:    'onMessage' was used before it was defined.

   tutorial/quick-start.md
         386:27:   Parsing error: Unexpected token )

@flyme2bluemoon
Copy link
Contributor Author

Hey @ckerr,

I have fixed the unmatched bracket in tutorial/quick-start.md. However, the "used before define" issue was already in the docs before this PR.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 26, 2021
@zcbenz zcbenz merged commit c0e72bd into electron:main Aug 2, 2021
1 check passed
@welcome
Copy link

welcome bot commented Aug 2, 2021

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Aug 2, 2021

No Release Notes

BlackHole1 pushed a commit to BlackHole1/electron that referenced this pull request Aug 30, 2021
…de (electron#30194)

* docs: Update to the use of arrow functions in line with the style guide

* docs: Fixed unmatched bracket typo in previous commit 9ebe3e5

* fix linting

Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
malept added a commit to malept/electron that referenced this pull request Sep 8, 2021
@trop
Copy link
Contributor

trop bot commented Sep 8, 2021

@malept has manually backported this PR to "15-x-y", please check out #30881

@trop trop bot added the in-flight/15-x-y label Sep 8, 2021
@malept
Copy link
Member

malept commented Sep 8, 2021

@malept has manually backported this PR to "15-x-y", please check out #30881

This is a partial backport...

zcbenz pushed a commit that referenced this pull request Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants