Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase stack size on windows x86 #30242

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jul 22, 2021

Backport of #29474

See that PR for details.

Notes: fix stack overflow crash in v8 on windows 32-bit builds

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 22, 2021
@trop trop bot mentioned this pull request Jul 22, 2021
2 tasks
@trop trop bot added 14-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jul 22, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 22, 2021
@zcbenz zcbenz force-pushed the trop/14-x-y-bp-fix-increase-stack-size-on-windows-x86-1626983385097 branch from 6a9b4d9 to 371533e Compare July 26, 2021 08:46
@zcbenz
Copy link
Member

zcbenz commented Jul 26, 2021

Doing a force push to restart the lint CI.

@zcbenz zcbenz merged commit ee491c0 into 14-x-y Jul 26, 2021
@zcbenz zcbenz deleted the trop/14-x-y-bp-fix-increase-stack-size-on-windows-x86-1626983385097 branch July 26, 2021 11:19
@release-clerk
Copy link

release-clerk bot commented Jul 26, 2021

Release Notes Persisted

fix stack overflow crash in v8 on windows 32-bit builds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
14-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants