Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change gin::Wrappable crash key type to ScopedCrashKey #30609

Merged
merged 2 commits into from
Aug 25, 2021
Merged

fix: change gin::Wrappable crash key type to ScopedCrashKey #30609

merged 2 commits into from
Aug 25, 2021

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Aug 18, 2021

Backport of #30578

See that PR for details.

Notes: none

@trop trop bot requested a review from a team as a code owner August 18, 2021 20:52
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 18, 2021
@trop trop bot requested a review from VerteDinde August 18, 2021 20:52
@trop trop bot mentioned this pull request Aug 18, 2021
Merged
5 tasks
@trop trop bot added 14-x-y backport This is a backport PR semver/none labels Aug 18, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 18, 2021
zcbenz
zcbenz requested changes Aug 19, 2021
View reviewed changes
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes as build is failing on arm64 macOS.

@deepak1556 @VerteDinde
fix: build dependency
a2c7187 
Dependency was missed in cbeae20
VerteDinde
VerteDinde approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added an upstream fix from master, tests now passing 🙂

@VerteDinde VerteDinde requested a review from zcbenz August 25, 2021 17:52
@zcbenz zcbenz merged commit 832c6c0 into 14-x-y Aug 25, 2021
@zcbenz zcbenz deleted the trop/14-x-y-bp-fix-change-gin-wrappable-crash-key-type-to-scopedcrashkey-1629319927366 branch August 25, 2021 23:29
@release-clerk
Copy link

release-clerk bot commented Aug 25, 2021

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
14-x-y backport This is a backport PR semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zcbenz @VerteDinde @MarshallOfSound @deepak1556