build: embed binary checksums in the npm package #30647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
zcbenz
reviewed
Aug 23, 2021
malept
suggested changes
Aug 23, 2021
There was a problem hiding this comment.
I don't recommend merging this until this packaging error on the latest nightly is investigated.
MarshallOfSound
force-pushed
the
trop/15-x-y-bp-build-embed-binary-checksums-in-the-npm-package-1629397592741
branch
from
9f4771f
to
2a88728
Compare
MarshallOfSound
approved these changes
Sep 8, 2021
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
* Replaces request with got * Replaces nugget with got streams * Replaces request in docs with got * Upgrades dugite to drop requests dependency
MarshallOfSound
force-pushed
the
trop/15-x-y-bp-build-embed-binary-checksums-in-the-npm-package-1629397592741
branch
from
2a88728
to
cbc3755
Compare
zcbenz
approved these changes
Sep 16, 2021
zcbenz
deleted the
trop/15-x-y-bp-build-embed-binary-checksums-in-the-npm-package-1629397592741
branch
|
No Release Notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #30611
See that PR for details.
Notes: no-notes