Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add types to webRequest filter #30914

Merged
merged 1 commit into from
Feb 27, 2023
Merged

feat: add types to webRequest filter #30914

merged 1 commit into from
Feb 27, 2023

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Sep 10, 2021 •
edited

Description of Change

Fixes #10867

Checklist

Release Notes

Notes: Added types to webRequest filter.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 10, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 17, 2021
@zcbenz zcbenz added the wip ⚒ label Sep 21, 2021
@miniak miniak force-pushed the miniak/web-request-filter-types branch from 07d2bf6 to f09c163 Compare February 3, 2023 15:07
@miniak miniak added semver/minor backwards-compatible functionality no-backport labels Feb 3, 2023
@miniak miniak removed the wip ⚒ label Feb 3, 2023
@miniak miniak marked this pull request as ready for review February 3, 2023 15:18
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 3, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 10, 2023
erickzhao
erickzhao approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

nornagon
nornagon requested changes Feb 17, 2023
View reviewed changes
docs/api/structures/web-request-filter.md Outdated Show resolved Hide resolved
shell/browser/api/electron_api_web_request.h Show resolved Hide resolved
spec/api-web-request-spec.ts Outdated Show resolved Hide resolved
@miniak miniak force-pushed the miniak/web-request-filter-types branch 3 times, most recently from 59f600d to 3c049f0 Compare February 24, 2023 22:08
@miniak miniak requested a review from nornagon February 24, 2023 22:09
@miniak miniak force-pushed the miniak/web-request-filter-types branch from 3c049f0 to a7cf321 Compare February 24, 2023 22:12
@miniak miniak force-pushed the miniak/web-request-filter-types branch from a7cf321 to 0871531 Compare February 24, 2023 22:18
@miniak miniak added target/24-x-y PR should also be added to the "24-x-y" branch. and removed no-backport labels Feb 24, 2023
zcbenz
zcbenz approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

nornagon
nornagon approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@nornagon nornagon merged commit ed7b5c4 into main Feb 27, 2023
@nornagon nornagon deleted the miniak/web-request-filter-types branch February 27, 2023 19:17
@release-clerk
Copy link

release-clerk bot commented Feb 27, 2023

Release Notes Persisted

Added types to webRequest filter.

@trop trop bot mentioned this pull request Feb 27, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Feb 27, 2023

I have automatically backported this PR to "24-x-y", please check out #37427

@trop trop bot added in-flight/24-x-y and removed target/24-x-y PR should also be added to the "24-x-y" branch. labels Feb 27, 2023
gecko19 pushed a commit to brightsign/electron that referenced this pull request Feb 28, 2023
@miniak @gecko19
feat: add types to webRequest filter (electron#30914)
dc22d25
@trop trop bot added merged/24-x-y PR was merged to the "24-x-y" branch and removed in-flight/24-x-y labels Mar 2, 2023
@commit-lint commit-lint bot mentioned this pull request May 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@zcbenz zcbenz zcbenz approved these changes

@erickzhao erickzhao erickzhao approved these changes

@BlackHole1 BlackHole1 Awaiting requested review from BlackHole1

@codebytere codebytere Awaiting requested review from codebytere

Assignees
No one assigned
Labels
api-review/approved ✅ merged/24-x-y PR was merged to the "24-x-y" branch semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add types property to onHeaderReceived's filter parameter.
4 participants
@miniak @nornagon @zcbenz @erickzhao