Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disabling and enabling resizability on macOS #31013

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Sep 17, 2021

Backport of #30999

See that PR for details.

Notes: Fixes an issue where multiple calls toBrowserWindow.setResizable() can cause the zoom button to incorrectly be disabled on macOS.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 17, 2021
@trop trop bot requested a review from codebytere September 17, 2021 13:54
@trop trop bot added 14-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Sep 17, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 17, 2021
@zcbenz zcbenz merged commit 33b8d51 into 14-x-y Sep 20, 2021
@zcbenz zcbenz deleted the trop/14-x-y-bp-fix-disabling-and-enabling-resizability-on-macos-1631886882329 branch September 20, 2021 00:35
@release-clerk
Copy link

release-clerk bot commented Sep 20, 2021

Release Notes Persisted

Fixes an issue where multiple calls toBrowserWindow.setResizable() can cause the zoom button to incorrectly be disabled on macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
14-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants