Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: propagate window.open settings to child window #31048

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Sep 21, 2021

Backport of #31031

See that PR for details.

Notes: Fixed child windows not inheriting the correct transparency and background color settings.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 21, 2021
@trop trop bot requested a review from VerteDinde September 21, 2021 16:06
@trop trop bot added 14-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Sep 21, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 21, 2021
@zcbenz zcbenz merged commit 29f6a92 into 14-x-y Sep 22, 2021
@zcbenz zcbenz deleted the trop/14-x-y-bp-fix-propagate-window-open-settings-to-child-window-1632240399904 branch September 22, 2021 00:31
@release-clerk
Copy link

release-clerk bot commented Sep 22, 2021

Release Notes Persisted

Fixed child windows not inheriting the correct transparency and background color settings.

Copy link

@Rickybrow Rickybrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accept leaving github away approach now reset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
14-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants