Optionally allow NTLM authentication for all domains #3120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
added a commit
that referenced
this pull request
Oct 20, 2015
Optionally allow NTLM authentication for all domains
zcbenz
added a commit
that referenced
this pull request
Oct 20, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR along with electron-archive/brightray#157, adds a new API to app:
We are discovering that many domains are incorrectly configured, so that NTLM will not be implicitly passed to a web server because Windows (via IInternetSecurityManager::MapUrlToZone) will decide it isn't inside the local domain. This PR allows app developers to say, "Don't care about URLs, always send NTLM if asked". If this method is not called, the preexisting behavior will be used
We actually set up an in-house Domain Controller to test this, it appears to be 💎