Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly notify WebViewGuestDelegate when webview is detached #31374

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Oct 11, 2021

Backport of #31350

See that PR for details.

Notes: Fix crash when changing zoom level for webview.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 11, 2021
@trop trop bot requested a review from zcbenz October 11, 2021 00:34
@trop trop bot added 14-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Oct 11, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 11, 2021
@zcbenz zcbenz merged commit 7a3541d into 14-x-y Oct 11, 2021
@zcbenz zcbenz deleted the trop/14-x-y-bp-fix-correctly-notify-webviewguestdelegate-when-webview-is-detached-1633912429194 branch October 11, 2021 05:36
@release-clerk
Copy link

release-clerk bot commented Oct 11, 2021

Release Notes Persisted

Fix crash when changing zoom level for webview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
14-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant