Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mac window crash native theme update #31428

Merged
merged 1 commit into from
Oct 15, 2021
Merged

fix: mac window crash native theme update #31428

merged 1 commit into from
Oct 15, 2021

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Oct 14, 2021

Backport of #31329

See that PR for details.

Notes: Fixes a potential crash when setting nativeTheme.themeSource on macOS.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 14, 2021
@trop trop bot mentioned this pull request Oct 14, 2021
Merged
3 tasks
@trop trop bot added 14-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Oct 14, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 14, 2021
@zcbenz zcbenz merged commit 15454fd into 14-x-y Oct 15, 2021
@zcbenz zcbenz deleted the trop/14-x-y-bp-fix-mac-window-crash-native-theme-update-1634233005355 branch October 15, 2021 00:06
@release-clerk
Copy link

release-clerk bot commented Oct 15, 2021

Release Notes Persisted

Fixes a potential crash when setting nativeTheme.themeSource on macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
14-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zcbenz @samuelmaddock