remote: track listeners on browser side #3251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,6 +3,9 @@ path = require 'path' | |||
| objectsRegistry = require './objects-registry.js' | |||
| v8Util = process.atomBinding 'v8_util' | |||
|
|
|||
| # weak refereence to callback with their registry ID. | |||
There was a problem hiding this comment.
First character of comment line should be capitalized.
|
The |
|
@zcbenz have made the changes. |
deepak1556
force-pushed
the
remote_callback_patch
branch
from
b483f71
to
cfb1769
Compare
|
Using |
| @@ -70,6 +74,9 @@ unwrapArgs = (sender, args) -> | |||
| returnValue = metaToValue meta.value | |||
| -> returnValue | |||
| when 'function' | |||
| if rendererCallbacks.has(meta.id) | |||
There was a problem hiding this comment.
Different WebContents can send callbacks with the same ID.
deepak1556
force-pushed
the
remote_callback_patch
branch
2 times, most recently
from
a449435
to
f37e0c3
Compare
| if not rendererCallbacks? | ||
| # Weak reference to callbacks with their ID | ||
| rendererCallbacks = new IDWeakMap() | ||
| rendererRegistry[webContentsId] = rendererCallbacks |
There was a problem hiding this comment.
The rendererCallbacks should be destroyed when the render view of webContents is destroyed.
|
Can you reimplement |
deepak1556
force-pushed
the
remote_callback_patch
branch
2 times, most recently
from
826af98
to
d047f1f
Compare
deepak1556
force-pushed
the
remote_callback_patch
branch
from
d047f1f
to
2c59f45
Compare
|
Thanks. |
zcbenz
added a commit
that referenced
this pull request
Oct 31, 2015
remote: track listeners on browser side
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3229