[Bug]: minWidth no longer working

[t57ser]

Preflight Checklist

• I have read the Contributing Guidelines for this project.
• I agree to follow the Code of Conduct that this project adheres to.
• I have searched the issue tracker for a bug report that matches the one I want to file, without success.

Electron Version

17.0.0-beta.7

What operating system are you using?

Windows

Operating System Version

Windows 10 19042.985

What arch are you using?

x64

Last Known Working Electron version

16

Expected Behavior

Setting minWidth for a browserWindow during creation should work

Actual Behavior

minWidth does not work (minHeight does)

const { app, BrowserWindow } = require("electron");

function init() {
	let browserWindow1 = new BrowserWindow({
		show: true,
		minWidth: 500,
		minHeight: 500,
	});
}

app.on("ready", () => {
	init();
});

Note: It works when using browserWindow1.setMinimumSize(500, 500);

Testcase Gist URL

No response

Additional Information

No response

[codebytere]

Looks like this regressed in v17.0.0-alpha.3...v17.0.0-alpha.4 and within that, b6f8a16 seems like the likely culprit - cc @CezaryKulakowski

[CezaryKulakowski]

My changes are in method HWNDMessageHandler::SizeWindowToAspectRatio which is called only when aspect ratio is set on the BrowserWindow. As test case from this bug doesn't set it I'd suspect that some change in the chromium intake causes the problem. I'll take a look at a later time.

[CezaryKulakowski]

I can confirm that it's definitely not caused by b6f8a16. My change modifies file ui/views/win/hwnd_message_handler.cc which is being compiled only on Windows and the regression with minWidth can be observed also on macOS.

[nornagon]

lol found it, it's this:

|| short-circuits, | does not.