Update dialog.md #3281
Merged
Update dialog.md #3281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarification of showErrorBox behavior on Linux if called before app `ready` event.
| @@ -114,4 +114,5 @@ will be passed via `callback(response)`. | |||
| Displays a modal dialog that shows an error message. | |||
|
|
|||
| This API can be called safely before the `ready` event the `app` module emits, | |||
| it is usually used to report errors in early stage of startup. | |||
| it is usually used to report errors in early stage of startup. If called before the app `ready` | |||
| +event on Linux, the message will be emitted to stderr, and no GUI dialog will appear. | |||
There was a problem hiding this comment.
Here is an extra +, also can you make the line fit in 80 columns?
|
Updated per comments from zcbenz |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarification of showErrorBox behavior on Linux if called before app
readyevent.