Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: SIGTRAP on callback of registerFileProtocol #32915

Closed
3 tasks done
thegnuu opened this issue Feb 15, 2022 · 3 comments
Closed
3 tasks done

[Bug]: SIGTRAP on callback of registerFileProtocol #32915

thegnuu opened this issue Feb 15, 2022 · 3 comments
Labels
17-x-y bug 🪲 has-repro-gist Issue can be reproduced with code at https://gist.github.com/ platform/macOS platform/windows status/confirmed A maintainer reproduced the bug or agreed with the feature
Projects

Comments

@thegnuu
Copy link

thegnuu commented Feb 15, 2022

Preflight Checklist

Electron Version

17.0.1

What operating system are you using?

macOS

Operating System Version

macOS Monterey 12.0.1

What arch are you using?

arm64 (including Apple Silicon)

Last Known Working Electron version

unknown

Expected Behavior

registerFileProtocol callback should return the file and not kill the application with a SIGTRAP.

Actual Behavior

If you try to load a file over a custom file protocol registered with registerFileProtocol electron should not crash.

Testcase Gist URL

https://gist.github.com/1a886dfdf51217d8e8450e3723a0bb63

Additional Information

Just click "Load iframe" in the Fiddle and Electron will crash, I tested this on windows as well with the same result.

@mlaurencin mlaurencin added 17-x-y has-repro-gist Issue can be reproduced with code at https://gist.github.com/ platform/macOS labels Feb 17, 2022
@mlaurencin mlaurencin added this to Unsorted Issues in 17-x-y Feb 17, 2022
@mlaurencin
Copy link
Contributor

This appears to be a problem from at least v14. Also Windows fails with Electron exited with code 2147483651.

@mlaurencin mlaurencin added platform/windows status/confirmed A maintainer reproduced the bug or agreed with the feature labels Feb 24, 2022
@VerteDinde VerteDinde moved this from Unsorted Issues to Does Not Block Stable in 17-x-y Feb 24, 2022
@dsanders11
Copy link
Member

I'm fairly certain this is a duplicate of #28407. Using registerStringProtocol here also causes a crash. Changing the gist here to load index.html via my-app:// doesn't crash.

Closing as a duplicate, please ping me if you think this is incorrect.

@george-thomas-hill
Copy link

@dsanders11 :

I'm still finding (in Electron 21.2.0) that loading a PDF in an iFrame fails to display the PDF, and loading a PDF in a webview crashes Electron.

Here's an Electron Fiddle gist that demonstrates this:

https://gist.github.com/george-thomas-hill/c3179e6eddeb1a2715201a20dbf95015

Could you please take another look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
17-x-y bug 🪲 has-repro-gist Issue can be reproduced with code at https://gist.github.com/ platform/macOS platform/windows status/confirmed A maintainer reproduced the bug or agreed with the feature
Projects
17-x-y
Does Not Block Stable
Development

No branches or pull requests

4 participants