Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove "cache" from app.getPath #33509

Merged
merged 1 commit into from Mar 31, 2022
Merged

docs: remove "cache" from app.getPath #33509

merged 1 commit into from Mar 31, 2022

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented Mar 30, 2022

Description of Change

It was accidentally added to public docs in #19480 and there is no description of it there. If we really want to expose this path, we should give it a more detailed name as it is hard to tell whether this path points to /tmp or ~/.cache.

Note that cache and userCache paths were added in Electron a long time ago and there are already some apps using them, so we can not remove them in code. They were not added to public docs because Electron does not support changing path of browser cache so exposing the paths would cause confusions.

Release Notes

Notes: none

@electron-cation electron-cation bot added semver/patch backwards-compatible bug fixes new-pr 🌱 PR opened in the last 24 hours labels Mar 30, 2022
@zcbenz zcbenz removed the semver/patch backwards-compatible bug fixes label Mar 30, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 31, 2022
@zcbenz zcbenz merged commit cbd06cd into main Mar 31, 2022
@zcbenz zcbenz deleted the remove-cache-doc branch March 31, 2022 00:33
@release-clerk
Copy link

release-clerk bot commented Mar 31, 2022

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants