ci: save Windows artifacts at end of job in case they fail #33510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
approved these changes
Mar 30, 2022
|
No Release Notes |
|
I was unable to backport this PR to "18-x-y" cleanly; |
|
I was unable to backport this PR to "17-x-y" cleanly; |
|
I was unable to backport this PR to "19-x-y" cleanly; |
|
/trop run backport |
|
The backport process for this PR has been manually initiated - here we go! :D |
bavulapati
pushed a commit
to bavulapati/electron
that referenced
this pull request
Apr 29, 2022
|
@VerteDinde has manually backported this PR to "19-x-y", please check out #34313 |
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Sometimes Appveyor has trouble uploading artifacts and this causes a build to be marked as failing when really the only thing that failed was saving artifacts to Azure storage. Since these artifacts are not necessary to determine whether a build was successful or not, this PR moves the uploads of the artifacts AFTER the tests instead of before the tests. This means that now the tests will run first and will not be blocked by artifact uploads failing.
Checklist
Release Notes
Notes: none