Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: upload to AZ as well as S3 #33573

Merged
merged 2 commits into from Apr 4, 2022
Merged

build: upload to AZ as well as S3 #33573

merged 2 commits into from Apr 4, 2022

Conversation

MarshallOfSound
Copy link
Member

This duplicates our upload logic so that all files are uploaded to both S3 and our new AZ storage containers. This patch also switches our checksum generation logic to use the AZ storage container exclusively.

Notes: no-notes

@MarshallOfSound MarshallOfSound requested a review from a team as a code owner April 1, 2022 19:13
@MarshallOfSound MarshallOfSound mentioned this pull request Apr 1, 2022
Closed
jkleinsc
jkleinsc approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming release builds run properly.

@codebytere codebytere changed the title build: upload to AZ aswell as S3 build: upload to AZ as well as S3 Apr 4, 2022
@MarshallOfSound
Copy link
Member Author

Gonna merge to test in the nightly, if it fails we can revert

@MarshallOfSound MarshallOfSound merged commit 204b53e into main Apr 4, 2022
@MarshallOfSound MarshallOfSound deleted the dual-upload branch April 4, 2022 09:32
@release-clerk
Copy link

release-clerk bot commented Apr 4, 2022

No Release Notes

@trop
Copy link
Contributor

trop bot commented Apr 4, 2022

I was unable to backport this PR to "15-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/15-x-y label Apr 4, 2022
@trop
Copy link
Contributor

trop bot commented Apr 4, 2022

I was unable to backport this PR to "16-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Apr 4, 2022

I was unable to backport this PR to "17-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Apr 4, 2022

I was unable to backport this PR to "18-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed target/16-x-y labels Apr 4, 2022
@trop trop bot mentioned this pull request Apr 4, 2022
Merged
@trop trop bot removed the target/19-x-y label Apr 4, 2022
@MarshallOfSound MarshallOfSound mentioned this pull request Apr 26, 2022
Merged
@trop
Copy link
Contributor

trop bot commented Apr 26, 2022

@MarshallOfSound has manually backported this PR to "18-x-y", please check out #33924

@MarshallOfSound MarshallOfSound mentioned this pull request Apr 26, 2022
Merged
@trop
Copy link
Contributor

trop bot commented Apr 26, 2022

@MarshallOfSound has manually backported this PR to "17-x-y", please check out #33925

@MarshallOfSound MarshallOfSound mentioned this pull request Apr 26, 2022
Merged
@trop
Copy link
Contributor

trop bot commented Apr 26, 2022

@MarshallOfSound has manually backported this PR to "16-x-y", please check out #33926

@MarshallOfSound MarshallOfSound mentioned this pull request Apr 26, 2022
Merged
@trop
Copy link
Contributor

trop bot commented Apr 26, 2022

@MarshallOfSound has manually backported this PR to "15-x-y", please check out #33927

bavulapati pushed a commit to bavulapati/electron that referenced this pull request Apr 29, 2022
@MarshallOfSound @bavulapati
build: upload to AZ as well as S3 (electron#33573)
a7b3e87 
* build: upload to AZ aswell as S3

* fix: provide env to azput
@commit-lint commit-lint bot mentioned this pull request Jun 1, 2022
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@MarshallOfSound @khalwa
build: upload to AZ as well as S3 (electron#33573)
5ee2d09 
* build: upload to AZ aswell as S3

* fix: provide env to azput
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@codebytere codebytere codebytere approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MarshallOfSound @jkleinsc @codebytere @VerteDinde