-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: use python3 to lint #33627
build: use python3 to lint #33627
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know my stamp has no effect here, but throwing a request changes on this.
I think if we should be more deliberate if we're going to make this change and choose to cut over to Python 3 entirely, rather than doing a change like this. Especially since a change like this affects pre-commit hooks and the likes.
- Our documentation lists Python 2 as a prerequisite
- Windows CI scripts currently install Python 2
build-tools
uses Python 2 for Windows- Not all OSs we support for building have a
python3
executable- As far as I can tell, macOS Mojave (10.14) and earlier don't come with Python 3, and the build instructions list support for >= 10.11.6
- If you use the official Python 3 installer on Windows, you won't get a
python3
executable, that's not a naming convention they implement there. However,python3
is a stub on Windows 10 which will take you to the Windows Store to install it via the store - yea, it's a headache
I'm not opposed to switching to officially switching over to Python 3 if we determine we can do so. However, this change feels like it will potentially cause problems on other OSs just to fix macOS Monterey.
Python 2 has been officially unsupported since Jan 1 2020. I'm not interested in spending any effort supporting it. However, we should (a) make sure our scripts actually work in Python 3 and (b) continue to function on Windows, those are important. |
I've removed some outdated Python 2 information from our docs, and also dropped some no-longer-current information about required macOS and SDK versions, as those now shift regularly as we track Chromium. |
FWIW... in working on the latest chromium roll, I came across this change to depot_tools: |
Alright, given that change upstream, I'm going to merge this. If depot_tools expects a |
No Release Notes |
I was unable to backport this PR to "15-x-y" cleanly; |
I have automatically backported this PR to "16-x-y", please check out #33716 |
I have automatically backported this PR to "17-x-y", please check out #33717 |
I have automatically backported this PR to "19-x-y", please check out #33718 |
I have automatically backported this PR to "18-x-y", please check out #33719 |
Followup: #33720 |
Description of Change
python
no longer exists on macOS Monterey.Notes: none