Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Audion DevTools Extension not working in Electron #33935

Closed
3 tasks done
marcelblum opened this issue Apr 26, 2022 · 8 comments
Closed
3 tasks done

[Bug]: Audion DevTools Extension not working in Electron #33935

marcelblum opened this issue Apr 26, 2022 · 8 comments
Labels
bug 🪲 has-repro-gist Issue can be reproduced with code at https://gist.github.com/ stale

Comments

@marcelblum
Copy link

Preflight Checklist

Electron Version

13 through 18

What operating system are you using?

Windows

Operating System Version

Win 10 Pro 21H2

What arch are you using?

x64

Last Known Working Electron version

No response

Expected Behavior

A "Web Audio" tab/panel should appear in the DevTools. Audion is a DevTools extension for the Web Audio API.

Actual Behavior

The extension-ready event successfully fires and the extension appears to load, but a couple warnings appear in the console and the "Web Audio" tab never appears in the DevTools. The relevant warnings in the console are:
Permission 'debugger' is unknown or URL pattern is malformed
and
[5208:0426/153939.221:ERROR:CONSOLE(2)] "Uncaught TypeError: Cannot read properties of undefined (reading 'attach')", source: chrome-extension://clijboajkbjbbjkopfofddimcfaeochf/devtools.js (2)

Testcase Gist URL

https://github.com/marcelblum/audion-in-electron

Additional Information

Note: my test repo uses electron-devtools-installer for simplicity, but I also tested with vanilla loadExtension() on a manual build from source of Audion and got the same errors.

Also note: I tested and got the same results in several Electron versions 13 through 18. My test repo defaults to using Electron 16 for simplicity because in latest Electron 18 some additional, presumably unrelated errors appear in the console similar to #32133:
[10792:0426/153220.575:ERROR:CONSOLE(160)] "Electron sandbox_bundle.js script failed to run", source: node:electron/js2c/sandbox_bundle (160) [10792:0426/153220.575:ERROR:CONSOLE(160)] "TypeError: object null is not iterable (cannot read property Symbol(Symbol.iterator))", source: node:electron/js2c/sandbox_bundle (160)

Ref: GoogleChrome/audion#141

@jkleinsc
Copy link
Contributor

jkleinsc commented May 2, 2022

Thanks for reporting this and helping to make Electron better!

Because of time constraints, triaging code with third-party dependencies is usually not feasible for a small team like Electron's. Would it be possible for you to make a standalone testcase with only the code necessary to reproduce the issue? Electron Fiddle is a great tool for making small testcases and publishing them as gists that Electron maintainers can use.

If the bug you've found can be tested with a pass/fail test, please make the testcase exit 0 on success or nonzero on failure. The lets Electron's issue bot see what releases are affected by the bug by checking your test against different OSes and Electron versions.

I'm adding the blocked/need-repro label for this reason. After you make a test case, please link to it in a followup comment.

Thanks in advance! Your help is appreciated.

@marcelblum
Copy link
Author

@jkleinsc thanks, maybe you didn't see that I already included a test repo for this (https://github.com/marcelblum/audion-in-electron). If that's not sufficient let me know.

@codebytere
Copy link
Member

hey @marcelblum - it looks like this isn't working bc under the hood the chrome extension calls chrome.debugger.attach, which we currently don't support. I'll see if there's anything i can do.

@jkleinsc jkleinsc added has-repro-gist Issue can be reproduced with code at https://gist.github.com/ and removed blocked/need-repro Needs a test case to reproduce the bug labels May 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@github-actions github-actions bot added the stale label Oct 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2022

This issue has been closed due to inactivity, and will not be monitored. If this is a bug and you can reproduce this issue on a supported version of Electron please open a new issue and include instructions for reproducing the issue.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 5, 2022
@treeoflife111
Copy link

bump

@dawidjaniga
Copy link

Hey @codebytere 👋🏻
Did you by any chance find something which can be done here to run Audion extension?

@marcelblum Do you know other ways to debug Web Audio in Electron?

@marcelblum
Copy link
Author

@dawidjaniga nope just sweat and tears 🥲 Honestly I found Audion to be kinda janky and unstable even in regular Chrome anyway so just got used to not using it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 has-repro-gist Issue can be reproduced with code at https://gist.github.com/ stale
Projects
None yet
Development

No branches or pull requests

5 participants