Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Crash on Windows when calling win.setTitleBarOverlay on a window that has titleBarStyle != 'hidden' #34137

Closed
3 tasks done
kaizjen opened this issue May 8, 2022 · 0 comments · Fixed by #34140
Closed
3 tasks done

Comments

@kaizjen
Copy link

kaizjen commented May 8, 2022

Preflight Checklist

Electron Version

18.2.0

What operating system are you using?

Windows

Operating System Version

Windows 10 version 20H2, build 19042

What arch are you using?

x64

Last Known Working Electron version

18.1.0

Expected Behavior

When win.setTitleBarOverlay is called, apparently the only valid option for titleBarStyle is 'hidden'. So when win was created with titleBarStyle different from 'hidden', Electron should throw an error.

Actual Behavior

Electron crashes unexpectedly.

Testcase Gist URL

https://gist.github.com/wheezard/207499979a7fda8cc7d874fdb87886fc

Additional Information

This might work on older versions, but I haven't tested it in them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants