Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: modernize ListValue usage in dict_util.mm and related files #34661

Merged
merged 5 commits into from
Jun 23, 2022

Conversation

nornagon
Copy link
Member

Description of Change

Modernize ListValue usage in dict_util and related files.

Notes: none

@nornagon nornagon added no-backport semver/patch backwards-compatible bug fixes labels Jun 20, 2022
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Jun 20, 2022
@nornagon nornagon requested review from a team as code owners June 22, 2022 19:14
@nornagon nornagon force-pushed the modernize-listvalue-dictutil branch from 02971f9 to 61db3f8 Compare June 22, 2022 22:42
@nornagon nornagon removed request for a team June 22, 2022 22:43
@zcbenz zcbenz merged commit 11924bd into main Jun 23, 2022
@zcbenz zcbenz deleted the modernize-listvalue-dictutil branch June 23, 2022 06:28
@release-clerk
Copy link

release-clerk bot commented Jun 23, 2022

No Release Notes

schetle pushed a commit to schetle/electron that referenced this pull request Nov 3, 2022
…lectron#34661)

* chore: modernize ListValue usage in dict_util.mm and related files

* use base::Value::{Dict,List} instead of raw base::Value

* fix compile

* fix build

* fix build again
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
…lectron#34661)

* chore: modernize ListValue usage in dict_util.mm and related files

* use base::Value::{Dict,List} instead of raw base::Value

* fix compile

* fix build

* fix build again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants