Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: BrowserWindow's "moved" event isn't triggered when using aero snap #34741

Closed
3 tasks done
FlysoftBeta opened this issue Jun 26, 2022 · 12 comments
Closed
3 tasks done
Assignees
Labels
20-x-y bug 🪲 has-repro-gist Issue can be reproduced with code at https://gist.github.com/ platform/windows

Comments

@FlysoftBeta
Copy link

Preflight Checklist

Electron Version

20.0.0-beta.2

What operating system are you using?

Windows

Operating System Version

Windows 11 version 22h2

What arch are you using?

x64

Last Known Working Electron version

all

Expected Behavior

The event should be triggered

Actual Behavior

When I use Win+LeftArrow, Win+RightArrow, or drag the window to the top of screen to move the window to one side, the window is moved, but its "moved" event is not triggered.
image

Testcase Gist URL

https://gist.github.com/6df4f13d195cabe34d1d35142e516b94

Additional Information

No response

@mlaurencin mlaurencin added platform/windows has-repro-gist Issue can be reproduced with code at https://gist.github.com/ 20-x-y labels Jun 29, 2022
@mlaurencin
Copy link
Contributor

@FlysoftBeta I attempted to run your gist on earlier versions and did not see this function as described in your expected behavior. Do you have a specific version you tested that worked?

@FlysoftBeta
Copy link
Author

I tried it on 16.0.0 and it had the same behavior, and I test it on Windows 11.

@FlysoftBeta
Copy link
Author

test.mp4

Here is the test video

@mlaurencin
Copy link
Contributor

This videos seems to indicate that it also did not display the expected behavior in 16.0.0. I tested on both Windows 11 and Windows 10 versions 20.0.0-beta.2 and 16.0.0 and did not see the event triggered in any of the cases. If there was no previous version in which the moved event was triggered, I think this would be considered a new feature rather than a bug.

@FlysoftBeta
Copy link
Author

Yes, but I don't know why it doesn't even trigger the resized event... I need to change the layout by listening the resized event.
And hope you can add this feature in future versions. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@github-actions github-actions bot added the stale label Oct 5, 2022
@pushkin-
Copy link

Repros in Electron 21 with this gist

Tangentially related aerosnap issue

@github-actions github-actions bot removed the stale label Oct 12, 2022
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@github-actions github-actions bot added the stale label Jan 11, 2023
@pushkin-
Copy link

repros in v22 with gist above

@github-actions github-actions bot removed the stale label Jan 12, 2023
@mlaurencin
Copy link
Contributor

Unfortunately, as stated in the linked feature request above, the OS does not provide this aero snap information to us. I will close this issue now, but if the information is provided in the future, then a new feature request can be submitted.

@FlysoftBeta
Copy link
Author

Although the problem has not been solved yet, thanks for your efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
20-x-y bug 🪲 has-repro-gist Issue can be reproduced with code at https://gist.github.com/ platform/windows
Projects
No open projects
Status: Does Not Block Stable
Development

No branches or pull requests

4 participants
@pushkin- @mlaurencin @FlysoftBeta and others